Add uv support to installation scripts for faster package installation #3486
Conversation
Added support for uv package manager installation and updated installation logic to use uv if available. Modified logging and error handling for better user guidance.
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Hi @Boulaouaney , thanks for your interest and for the PR! I like the idea of using uv if it exists but don't think we should add new parameters to the scripts. Also please modify only the parts related to this PR (i.e. do not remove comments or alter existing logic). I have left a few comments to guide you a bit.
If this PR is AI-generated, please let us know in advance and please review the AI-generated diff' to check it really makes sense.
Thanks in advance!
|
@Wauplin thanks for the detailed feedback! I did indeed use Claude Code to refactor, and tested on my home setup through ssh on my phone as I am currently traveling and don't have direct access to a computer. I will go through and address all your comments as soon as I can. |
Removed newly added paramters Put back comments Use uv only if installed Do not create venv with uv
|
@Wauplin sorry for the delay on the PR. I hope I addressed all of your feedback with my latest commits. Please let me know if I missed sonething |
2 participants
Summary
Adds support for the
uvpackage manager to both Unix and Windows installation scripts, providing 10-100x faster package installation while maintaining full backwards compatibility with pip.Changes
ensure_uv()function and uv-based venv/package installationInstall-Uvfunction and uv-based installation flow--no-uvflag (Unix) and-NoUvparameter (Windows) to explicitly use pipHF_CLI_USE_UVenvironment variable (defaults totrue)Benefits
Testing
Tested on:
Both platforms work correctly with uv enabled and fall back gracefully to pip when needed.
Backwards Compatibility
--no-uv/-NoUvor environment variable